Skip to content

Conversation

@ARRY7686
Copy link

@ARRY7686 ARRY7686 commented Nov 4, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
This PR enhances the logging for selected clusters in the generic scheduler. It introduces detailed cluster summaries in the log output when the verbosity level is high, improving the traceability and debuggability of scheduling operations.

Which issue(s) this PR fixes:

Fixes #6880

Special notes for your reviewer:

  • Added more comprehensive log messages for selected clusters.
  • Helps developers trace scheduling behavior during high verbosity debugging sessions.

Does this PR introduce a user-facing change?:

Enhance logging for selected clusters in the generic scheduler, adding detailed cluster summaries when verbosity level is high.

… detailed cluster summaries to the log output when verbosity level is high, improving traceability during scheduling operations.
Copilot AI review requested due to automatic review settings November 4, 2025 11:37
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 4, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign whitewindmills for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot
Copy link
Collaborator

Welcome @ARRY7686! It looks like this is your first PR to karmada-io/karmada 🎉

@gemini-code-assist
Copy link

Summary of Changes

Hello @ARRY7686, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the logging capabilities within the karmada-scheduler's generic scheduler component. The primary goal is to make the log output for selected clusters more informative and readable. By introducing detailed summaries that include cluster names, scores, and available replicas at a higher verbosity level, the change aims to provide developers with better insights into scheduling decisions, thereby improving the overall debugging experience and operational understanding of the system.

Highlights

  • Improved Log Readability: The pull request addresses an issue where log messages for selected clusters in the karmada-scheduler were unreadable, making debugging difficult.
  • Detailed Cluster Summaries: When the verbosity level is set to V(4), the logs now include detailed summaries for each selected cluster, showing its name, score, and available replicas.
  • Enhanced Debuggability: This change significantly improves the traceability and debuggability of scheduling operations by providing more comprehensive information directly in the logs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request improves the logging for selected clusters in the generic scheduler by providing more detailed cluster summaries when the verbosity level is high. This enhances traceability and debuggability of scheduling operations. The changes are well-implemented and address the issue effectively.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the logging of selected clusters in the scheduler by providing more detailed information. Instead of simply logging the cluster objects, the code now formats the output to include cluster name, score, and available replicas in a more readable format.

  • Enhanced cluster selection logging to include structured details (name, score, available replicas)
  • Added performance optimization by checking log level before formatting expensive log strings
  • Added strings import to support the new formatting logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 46.38%. Comparing base (4b5aa6b) to head (2581ec5).

Files with missing lines Patch % Lines
pkg/scheduler/core/generic_scheduler.go 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6904   +/-   ##
=======================================
  Coverage   46.38%   46.38%           
=======================================
  Files         697      697           
  Lines       47751    47751           
=======================================
+ Hits        22149    22150    +1     
+ Misses      23933    23932    -1     
  Partials     1669     1669           
Flag Coverage Δ
unittests 46.38% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karmada-bot karmada-bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Nov 6, 2025
@karmada-bot
Copy link
Collaborator

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2025
@RainbowMango
Copy link
Member

@ARRY7686 Can you look at the failing lint warning? And you might need to rebase your code to get rid of the merge commit.
You can do that by following the commands:

- git fetch upstream
- git rebase upstream/master
- git push origin fix-logger-readability -f 

And after that, you need to squash commits.

@ARRY7686
Copy link
Author

ARRY7686 commented Nov 7, 2025

thanks so much for the help I will look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log message for selected clusters in karmada-scheduler is unreadable

4 participants