-
Notifications
You must be signed in to change notification settings - Fork 1k
[Fix] Log message for selected clusters in karmada-scheduler is unreadable #6904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… detailed cluster summaries to the log output when verbosity level is high, improving traceability during scheduling operations.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @ARRY7686! It looks like this is your first PR to karmada-io/karmada 🎉 |
Summary of ChangesHello @ARRY7686, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the logging capabilities within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request improves the logging for selected clusters in the generic scheduler by providing more detailed cluster summaries when the verbosity level is high. This enhances traceability and debuggability of scheduling operations. The changes are well-implemented and address the issue effectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the logging of selected clusters in the scheduler by providing more detailed information. Instead of simply logging the cluster objects, the code now formats the output to include cluster name, score, and available replicas in a more readable format.
- Enhanced cluster selection logging to include structured details (name, score, available replicas)
- Added performance optimization by checking log level before formatting expensive log strings
- Added
stringsimport to support the new formatting logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6904 +/- ##
=======================================
Coverage 46.38% 46.38%
=======================================
Files 697 697
Lines 47751 47751
=======================================
+ Hits 22149 22150 +1
+ Misses 23933 23932 -1
Partials 1669 1669
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ARRY7686 Can you look at the failing lint warning? And you might need to rebase your code to get rid of the And after that, you need to squash commits. |
|
thanks so much for the help I will look into it |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR enhances the logging for selected clusters in the generic scheduler. It introduces detailed cluster summaries in the log output when the verbosity level is high, improving the traceability and debuggability of scheduling operations.
Which issue(s) this PR fixes:
Fixes #6880
Special notes for your reviewer:
Does this PR introduce a user-facing change?: