Skip to content

Commit 8a32131

Browse files
committed
comment updated and test file removed!
Signed-off-by: rohan-019 <[email protected]>
1 parent 2a66b70 commit 8a32131

File tree

2 files changed

+1
-64
lines changed

2 files changed

+1
-64
lines changed

pkg/controllers/execution/execution_controller.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,16 +140,14 @@ func (c *Controller) SetupWithManager(mgr controllerruntime.Manager) error {
140140
RateLimiter: ratelimiterflag.DefaultControllerRateLimiter[controllerruntime.Request](c.RateLimiterOptions),
141141
})
142142

143-
// Build predicates: ignore delete events, and handle push/pull cluster filtering
143+
// Ignore delete events; the deletion process will be handled by the deletion timestamp set.
144144
deleteIgnorePred := predicate.Funcs{
145145
DeleteFunc: func(event.DeleteEvent) bool { return false },
146146
}
147147

148148
if c.WorkPredicateFunc != nil {
149-
// Combine custom predicate with delete ignore for karmada-controller-manager (push) mode
150149
ctrlBuilder.For(&workv1alpha1.Work{}, builder.WithPredicates(c.WorkPredicateFunc, deleteIgnorePred))
151150
} else {
152-
// karmada-agent (pull) mode - just ignore delete events
153151
ctrlBuilder.For(&workv1alpha1.Work{}, builder.WithPredicates(deleteIgnorePred))
154152
}
155153

pkg/controllers/execution/execution_controller_predicate_test.go

Lines changed: 0 additions & 61 deletions
This file was deleted.

0 commit comments

Comments
 (0)