push-cluster-pred removed!

rohan-019 · rohan-019 · commit 2a66b70b9363 · 2025-10-21T12:17:43.000+05:30
Signed-off-by: rohan-019 &lt;rohan18126@gmail.com&gt;
diff --git a/pkg/controllers/execution/execution_controller.go b/pkg/controllers/execution/execution_controller.go
@@ -146,12 +146,11 @@ func (c *Controller) SetupWithManager(mgr controllerruntime.Manager) error {
 	}
 
 	if c.WorkPredicateFunc != nil {
-		// Combine custom predicate with delete ignore
+		// Combine custom predicate with delete ignore for karmada-controller-manager (push) mode
 		ctrlBuilder.For(&workv1alpha1.Work{}, builder.WithPredicates(c.WorkPredicateFunc, deleteIgnorePred))
 	} else {
-		// Use push cluster predicate with delete ignore for karmada-controller-manager mode
-		pushClusterPred := helper.WorkWithinPushClusterPredicate(mgr)
-		ctrlBuilder.For(&workv1alpha1.Work{}, builder.WithPredicates(pushClusterPred, deleteIgnorePred))
+		// karmada-agent (pull) mode - just ignore delete events
+		ctrlBuilder.For(&workv1alpha1.Work{}, builder.WithPredicates(deleteIgnorePred))
 	}
 
 	return ctrlBuilder.Complete(c)

Original file line number	Diff line number	Diff line change
`@@ -146,12 +146,11 @@ func (c *Controller) SetupWithManager(mgr controllerruntime.Manager) error {`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`if c.WorkPredicateFunc != nil {`
`149`		`- // Combine custom predicate with delete ignore`
	`149`	`+ // Combine custom predicate with delete ignore for karmada-controller-manager (push) mode`
`150`	`150`	`ctrlBuilder.For(&workv1alpha1.Work{}, builder.WithPredicates(c.WorkPredicateFunc, deleteIgnorePred))`
`151`	`151`	`} else {`
`152`		`- // Use push cluster predicate with delete ignore for karmada-controller-manager mode`
`153`		`- pushClusterPred := helper.WorkWithinPushClusterPredicate(mgr)`
`154`		`- ctrlBuilder.For(&workv1alpha1.Work{}, builder.WithPredicates(pushClusterPred, deleteIgnorePred))`
	`152`	`+ // karmada-agent (pull) mode - just ignore delete events`
	`153`	`+ ctrlBuilder.For(&workv1alpha1.Work{}, builder.WithPredicates(deleteIgnorePred))`
`155`	`154`	`}`
`156`	`155`
`157`	`156`	`return ctrlBuilder.Complete(c)`