Skip to content

Improve nullable annotations for Result.Error #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3Matvey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve nullable annotations for Result.Error #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Common/ResultPattern/Result.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Text.Json.Serialization;
using System.Diagnostics.CodeAnalysis;
using System.Text.Json.Serialization;

namespace Common.ResultPattern;

Expand All @@ -22,13 +23,15 @@ protected Result()
/// <param name="error">The error associated with the failed result.</param>
protected Result(Error error)
{
ArgumentNullException.ThrowIfNull(error);
IsSuccess = false;
Error = error;
}

/// <summary>
/// Gets a value indicating whether the result is successful.
/// </summary>
[MemberNotNullWhen(false, nameof(Error))]
public bool IsSuccess { get; }

/// <summary>
Expand Down