ensure opts from writer is used to generate hypercore#46
Open
m4gpi wants to merge 1 commit intokappa-db:masterfrom
Open
ensure opts from writer is used to generate hypercore#46m4gpi wants to merge 1 commit intokappa-db:masterfrom
m4gpi wants to merge 1 commit intokappa-db:masterfrom
Conversation
Member
|
Thanks for the patch! Would you be open to using Could you also add a note in the README about this new |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables per-hypercore opts to be used over default set by multifeed instance. We need this in kappa-drive for an update to hyperdrive, see here:
https://gitlab.com/coboxcoop/kappa-drive/-/merge_requests/4/diffs#a77b15c0d64cf6111e025645e562faf8ccabb9d7_427_427
We're using multifeed's writer function to generate feeds, then creating a trie and hyperdrive out of those returned feeds. This custom opts allows us to create a trie with
{ valueEncoding: 'binary' }, which is different to the other's feeds encodings.