Salactus ttl#3
Open
kapilt wants to merge 72 commits into
Open
Conversation
…size if age not avail on iteration
kapilt
pushed a commit
that referenced
this pull request
Jan 16, 2018
…dian#623) * Repushing branch Update #1 * added ‘keys’ as param to scan & validate keys are on the group and set to propagate. * added AutoScaleGroupName to Unittest for additional validation Update #2 * docstring added update #3 * removed worker * changed tag validation check to compare list content not length * updated unittest docstring indentation correction adding correct indentation to docstring update docstring * added newline. local make sphinx builds update #4 * updating docstring * adding ‘propagated’ and ‘match_all’ params adding permissions line * added permissions line to propagated-tags filter remove 'match_all' option * removed match_all option from function * will use full tag set to determine match condition * expanded docstring update #5 * replace ‘propagated’ parameter with ‘match’ to determine criteria - match = true will return all asg that have the tag set & all tags in the set are set to propagate - match = false will return all asg that do not have the tag set or have the set but not all tags are set to propagate * added second unittest for match = False * updating propagated check - adding option for propagated - if propagate is true, will look for a match/missing tag set for propagated tags - if propagate is false, will look for a match/missing tags set for non-propagated tags - adding unittests for non-propagated option (match & missing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.