Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the generic database wrapper types (DB[T], Tx[T], Stmt[T]) to embed interfaces instead of concrete types from the database/sql package. This architectural improvement increases flexibility and follows best practices by programming to interfaces rather than implementations.
Changes:
- Changed
DB[T],Tx[T], andStmt[T]to embed interfaces (iface.DB,iface.Tx,iface.Stmt) instead of concrete types (*sql.DB,*sql.Tx,*sql.Stmt) - Removed compile-time assertions from wrapper structs (they're no longer needed since the structs embed interfaces)
- Added a comprehensive example in
cmd/main.godemonstrating type-safe database operations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| db.go | Changed DB[T] to embed iface.DB interface instead of *sql.DB concrete type |
| tx.go | Changed Tx[T] to embed iface.Tx interface instead of *sql.Tx concrete type |
| stmt.go | Changed Stmt[T] to embed iface.Stmt interface instead of *sql.Stmt concrete type |
| cmd/main.go | Added new example demonstrating type-safe database operations with different database types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.