Optionally disable 'environment' feature#4
Optionally disable 'environment' feature#4timvaillancourt wants to merge 2 commits intokampka:masterfrom timvaillancourt:disable-environment
Conversation
|
First, all pull requests should come with new tests that verify the change works as expected and ideally also demonstrates the intended use case. Second, all pull requests should pass the tests ;) Can you explain to me what your use case is here? |
|
Thanks, ok. Interesting, yes I would optionally disable the 'concept' of environments in one use case because that app just never had any idea of config-environments before and it already uses -e for a different option. |
This is a working proof-of-concept to disable the environment feature - something I want to do in one of my use cases of yconf.
I am open to any changes/feedback to improve this change, match the code/naming style better, etc.
Also: seeing a 2nd bool arg is being added to BaseConfiguration.init, maybe this should move to keyword-args, like this below? I did that in my first test but didn't want to get carried away :)