Skip to content

Performance: Memoize Encryptor in ActiveRecordEncryptedString::Type #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bhacaz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Performance: Memoize Encryptor in ActiveRecordEncryptedString::Type #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b0ed32
memoization encryptor
Bhacaz May 6, 2025
627efc9
Lock concurrent-ruby
Bhacaz May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gemfiles/5_0_stable.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ source 'https://rubygems.org'

gem 'activerecord', '~> 5.0'
gem 'sqlite3', '~> 1.3.6'
gem 'concurrent-ruby', '1.3.4', require: false

gemspec path: '../'
1 change: 1 addition & 0 deletions gemfiles/5_1_stable.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
source 'https://rubygems.org'

gem 'activerecord', '~> 5.1'
gem 'concurrent-ruby', '1.3.4', require: false

gemspec path: '../'
1 change: 1 addition & 0 deletions gemfiles/5_2_stable.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
source 'https://rubygems.org'

gem 'activerecord', '~> 5.2'
gem 'concurrent-ruby', '1.3.4', require: false

gemspec path: '../'
1 change: 1 addition & 0 deletions gemfiles/6_0_stable.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
source 'https://rubygems.org'

gem 'activerecord', '~> 6.0'
gem 'concurrent-ruby', '1.3.4', require: false

gemspec path: '../'
1 change: 1 addition & 0 deletions gemfiles/6_1_stable.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
source 'https://rubygems.org'

gem 'activerecord', '~> 6.1'
gem 'concurrent-ruby', '1.3.4', require: false

gemspec path: '../'
1 change: 1 addition & 0 deletions gemfiles/7_0_stable.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
source 'https://rubygems.org'

gem 'activerecord', '~> 7.0'
gem 'concurrent-ruby', '1.3.4', require: false

gemspec path: '../'
3 changes: 2 additions & 1 deletion lib/active_record_encrypted_string/type.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ def changed_in_place?(raw_old_value, new_value)

def encryptor
# TODO: rotate
ActiveSupport::MessageEncryptor.new(secret, cipher: ActiveRecordEncryptedString.configuration.cipher_alg)
@encryptor ||=
ActiveSupport::MessageEncryptor.new(secret, cipher: ActiveRecordEncryptedString.configuration.cipher_alg)
end

def secret
Expand Down