References to objects in array documents and object documents#110
Open
kubak89 wants to merge 2 commits intokamikat:masterfrom
Open
References to objects in array documents and object documents#110kubak89 wants to merge 2 commits intokamikat:masterfrom
kubak89 wants to merge 2 commits intokamikat:masterfrom
Conversation
…ent that would allow finding referenced resources in ArrayDocument data list
…ment that would allow finding referenced resources in ObjectDocument data
kubak89
force-pushed
the
references-to-objects-in-array-documents-and-object-documents
branch
from
9ea5588 to
dbc984d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to this discussion on Json:API forums, resources in primary data may have relationships with other resources that are also there (e.g. two "people" type resources with HasOne relationships referencing each other in "spouse" field). The library have not supported such a case, so I added
find(ResourceIdentifier)method overrides inArrayDocumentandObjectDocumentthat allow searching for referenced Resource indatafield.