Relationship

[Manvitha-486]

PR Type

enhancement

---

Description

• Changed user schema to use email instead of phone number

• Updated email validation and formatting requirements

• Added 'vice president' as a valid user role

---

Changes walkthrough 📝

	Relevant files
Enhancement	UserSchema.js Switch to email-based user schema and expand roles              backend/models/UserSchema.js Replaced phoneNumber with mail as unique identifier Updated validation to require valid email format Added 'vice president' to allowed user roles Enforced lowercase for email addresses +4/-3

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-for-open-source]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Email Validation The email regex pattern is basic and might allow some invalid email formats. Consider using a more comprehensive regex or a validation library for emails. match: /^[^\s@]+@[^\s@]+\.[^\s@]+$/ }, Migration Strategy Changing from phone number to email as the unique identifier will require a data migration strategy for existing users. Ensure this is addressed in the implementation. mail: { type: String, required: true, unique: true, lowercase: true, match: /^[^\s@]+@[^\s@]+\.[^\s@]+$/ },

[qodo-merge-for-open-source]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Improve email validation The email regex pattern is too simple and may allow invalid email formats. Use a more comprehensive regex pattern that better validates email addresses, including proper domain validation and character restrictions. backend/models/UserSchema.js [4-10] mail: { type: String, required: true, unique: true, lowercase: true, - match: /^[^\s@]+@[^\s@]+\.[^\s@]+$/ + match: /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/ }, Apply this suggestion Suggestion importance[1-10]: 7 __ Why: The suggestion correctly points out that the existing email regex /^[^\s@]+@[^\s@]+\.[^\s@]+$/ is too simplistic. The proposed improved_code offers a more comprehensive regex, enhancing the robustness of email validation and improving data quality for the new mail field.	Medium
Update