Skip to content

Helm chart#7

Open
haloss1 wants to merge 12 commits intokaje94:mainfrom
haloss1:helm-chart
Open

Helm chart#7
haloss1 wants to merge 12 commits intokaje94:mainfrom
haloss1:helm-chart

Conversation

@haloss1
Copy link
Copy Markdown

@haloss1 haloss1 commented May 13, 2024

Hey, i made this helm chart to deploy menufic on Kubernetes, please feel free to review it.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

app: {{ printf "%s-%s" .Release.Name .Chart.Name }}
spec:
containers:
- name: {{ printf "%s-%s" .Release.Name .Chart.Name }}

Check warning

Code scanning / SonarCloud

CPU limits should be enforced

<!--SONAR_ISSUE_KEY:AY9vqfaYVy1vAvCUtK6x-->Specify a CPU limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=kaje94_menufic&issues=AY9vqfaYVy1vAvCUtK6x&open=AY9vqfaYVy1vAvCUtK6x&pullRequest=7">SonarCloud</a></p>
app: {{ printf "%s-%s" .Release.Name .Chart.Name }}
spec:
containers:
- name: {{ printf "%s-%s" .Release.Name .Chart.Name }}

Check warning

Code scanning / SonarCloud

Memory limits should be enforced

<!--SONAR_ISSUE_KEY:AY9vqfaYVy1vAvCUtK6y-->Specify a memory limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=kaje94_menufic&issues=AY9vqfaYVy1vAvCUtK6y&open=AY9vqfaYVy1vAvCUtK6y&pullRequest=7">SonarCloud</a></p>
metadata:
labels:
app: {{ printf "%s-%s" .Release.Name .Chart.Name }}
spec:

Check warning

Code scanning / SonarCloud

Service account tokens should not be mounted in pods

<!--SONAR_ISSUE_KEY:AY9vqfaYVy1vAvCUtK6z-->Set automountServiceAccountToken to false for this specification of kind Deployment. <p>See more on <a href="https://sonarcloud.io/project/issues?id=kaje94_menufic&issues=AY9vqfaYVy1vAvCUtK6z&open=AY9vqfaYVy1vAvCUtK6z&pullRequest=7">SonarCloud</a></p>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant