-
Notifications
You must be signed in to change notification settings - Fork 64
V3 Refactor - it's stylish, it's fast, it's more modern #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lorthiz
wants to merge
138
commits into
kaitai-io:master
Choose a base branch
from
Lorthiz:v3-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t KaitaiServices to Compiler module.
…ng formats and licenses
…ries, added testing library - mocha, docs cleanup, removed duplicated 3rd party libraries info
…KaitaiFsFiles treated as module
…ts for code evaluation functionality, initial restore of LazyInstances
…viour when file is deleted and it was selected
…ng onMountedEvents when filesystems were not ready, added dist folder instead of opening new window for each generated parser
…d tests written, imports for folders now work during parser generation, but only absolute imports are advised. Some other fixes and improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppURL: https://kaitai.lorthiz.ovh
Goal
Global refactor of the application. Currently my branch should have the same functionality as
devel, but also includes some QoL improvements, better responsiveness, modularity and up to date dependencies and libraries.Disclaimer
Right now I made sure that your new changes are also applied in my branch and that there is a way to merge this project without much hassle, but my MR were ignored in the past - so were my messages about MRs in Gitter. So without clear interest from your side I just plan to add more features to this branch not waiting for any response. And if it breaks then so be it.
Changelog
Architecture changes
jsfolder with custom build steps and copying node_module is goneHexViewer
File Tree
Things to consider before merging
Things I plan to work on next