-
-
Notifications
You must be signed in to change notification settings - Fork 159
BE: Metrics collection / storage / quering #1208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # api/build.gradle # api/src/main/java/io/kafbat/ui/mapper/DescribeLogDirsMapper.java # api/src/main/java/io/kafbat/ui/model/InternalLogDirStats.java # api/src/main/java/io/kafbat/ui/service/ReactiveAdminClient.java # gradle/libs.versions.toml
...src/main/java/io/kafbat/ui/service/metrics/scrape/prometheus/PrometheusTextFormatParser.java
Fixed
Show fixed
Hide fixed
...src/main/java/io/kafbat/ui/service/metrics/scrape/prometheus/PrometheusTextFormatParser.java
Fixed
Show fixed
Hide fixed
api/src/main/java/io/kafbat/ui/service/metrics/scrape/jmx/JmxMetricsFormatter.java
Fixed
Show fixed
Hide fixed
...src/main/java/io/kafbat/ui/service/metrics/scrape/prometheus/PrometheusTextFormatParser.java
Dismissed
Show dismissed
Hide dismissed
api/src/main/java/io/kafbat/ui/service/metrics/scrape/jmx/JmxMetricsFormatter.java
Fixed
Show fixed
Hide fixed
api/src/main/java/io/kafbat/ui/service/metrics/scrape/jmx/JmxMetricsFormatter.java
Dismissed
Show dismissed
Hide dismissed
Haarolean
requested changes
Aug 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments/qs
api/src/main/java/io/kafbat/ui/service/metrics/prometheus/PrometheusExpose.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/service/metrics/scrape/jmx/JmxMetricsRetriever.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/service/metrics/scrape/jmx/JmxMetricsRetriever.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/service/metrics/scrape/MetricsScrapping.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/service/metrics/scrape/MetricsScrapping.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/service/KafkaClusterFactory.java
Outdated
Show resolved
Hide resolved
Haarolean
reviewed
Aug 11, 2025
Haarolean
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact/changelog
A PR with changes which should be addressed in the changelog explicitly
scope/backend
Related to backend changes
status/triage/completed
Automatic triage completed
type/chore
Boring stuff, could be refactoring or tech debt
type/enhancement
En enhancement/improvement to an already existing feature
type/refactor
Refactoring task
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)