Skip to content

Conversation

@SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Jul 21, 2025

No description provided.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16749227858

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.09%) to 62.005%

Files with Coverage Reduction New Missed Lines %
controllers/drain_controller_helper.go 1 67.43%
controllers/helper.go 1 70.99%
pkg/daemon/daemon.go 3 48.39%
pkg/daemon/status.go 8 62.24%
Totals Coverage Status
Change from base Build 16649646391: -0.09%
Covered Lines: 8602
Relevant Lines: 13873

💛 - Coveralls

@SchSeba
Copy link
Collaborator Author

SchSeba commented Sep 8, 2025

Hi @zeeke @adrianchiris let me know if we can move forward with this

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one minor comment. otherwise LGTM

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchSeba
Copy link
Collaborator Author

SchSeba commented Sep 25, 2025

Hi @adrianchiris let me know if you are fine with the proposal so I can start working on the code implementation.

Thanks!

@SchSeba
Copy link
Collaborator Author

SchSeba commented Oct 19, 2025

ping @adrianchiris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants