Make ovs-vswitchd service 'other_config' option configurable

[e0ne]

No description provided.

[github-actions]

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.
• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
  Best regards.

[coveralls]

Pull Request Test Coverage Report for Build 19573326688

Details

• 118 of 163 (72.39%) changed or added relevant lines in 10 files are covered.
• 4 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.2%) to 62.238%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/render/render.go	16	18	88.89%
pkg/host/internal/service/service.go	30	36	83.33%
pkg/plugins/k8s/k8s_plugin.go	16	29	55.17%
pkg/host/mock/mock_host.go	0	24	0.0%

Files with Coverage Reduction	New Missed Lines	%
controllers/drain_controller_helper.go	1	67.43%
controllers/helper.go	1	70.99%
pkg/plugins/k8s/k8s_plugin.go	2	74.78%

Totals
Change from base Build 19534412227:	0.2%
Covered Lines:	8859
Relevant Lines:	14234

---

💛 - Coveralls

[adrianchiris]

So, here are my thoughts on this one:

we should use same API as we have in OVSBridgeConfig e.g have OVSGlobalConfig in the pool config object
for now we can allow to set other_config keys only.

in addition we should support clearing any global configurations which were set but are not relevant anymore.
this can be done by checking the last applied status we cache or by saving which keys were set by the operator in a special key part of openvswitch table external_ids e.g external_ids:sriov-operator-owned-keys

the ExecPre we got for the systemd service of openvswitch would need to be a bit more complex to achieve that.

i wonder if we want a design doc for this one WDYT ?

[github-actions]

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.
• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
  Best regards.

[github-actions]

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.
• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
  Best regards.

[e0ne]

/test-all-nvidia

[e0ne]

CI failures aren't related to this change

[github-actions]

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.
• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
  Best regards.