Connection limit for thick daemon. #1458
Open
+95
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karampok
reviewed
Nov 13, 2025
Signed-off-by: Julius Hinze <[email protected]>
juliusmh
force-pushed
the
jmh/limit_listener
branch
from
db9bce5 to
eb7efb0
Compare
SchSeba
reviewed
Dec 2, 2025
Contributor
SchSeba
left a comment
SchSeba
left a comment
There was a problem hiding this comment.
is it possible to add a test for this one?
maybe put the number really low just to be sure we will get a retry from the CRI system to try to start the pod again?
also just a general question can you try to run a pprof to see what part of the code is wasting memory potentially we can improve that area in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1346