Refactor intel e810/e825/e830 plugins #105
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
- Migrates .golangci-lint.yaml to the v2 syntax, preserving current configuration. - Updates the github hook to use the official golangci-lint-action runner. Signed-off-by: Jim Ramsay <[email protected]>
Split the monolithic intel_test.go into smaller, more focused test files: - e810_test.go: Tests for e810.go - e825_test.go: Tests for e825.go - e830_test.go: Tests for e830.go - clock-chain_test.go: Tests for clock-chain.go - phaseAdjust_test.go: Tests for phaseAdjust.go - mock_test.go: Mock filesystem and test helpers This improves test organization and readability. Assisted-by: gemini-2.5-pro Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
…oss all intel plugins Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
Signed-off-by: Jim Ramsay <[email protected]>
|
Thanks for your PR, |
|
Can we put a hold on this until Jim and I have a chance to discuss? |
Contributor
Author
|
On hold until OpenShift 4.22 branch |
Collaborator
|
Can you split the linter changes into a separate PR? |
| name string | ||
| hwplugins []string | ||
| defaultInitScript string | ||
| preferredClock string |
Collaborator
There was a problem hiding this comment.
What is the preferredClock?
Contributor
Author
There was a problem hiding this comment.
Ah, that's a bad name for it. It's the name of the dpll module we'll extract the clock from, if set. If not set (for e810) we fall back to the older PCI-based mechanism of retrieving the clock ID.
Collaborator
|
Can you confirm oc -n openshift-ptp get nodeptpdevice -o yaml works still? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This large string of commits: