Add Tolerations spec to chart configuration #221
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Miranda <[email protected]>
danielkza
force-pushed
the
add-tolerations-spec
branch
from
7af4230 to
d7c3afe
Compare
|
Is this PR being held up over just DCO? I am interested in seeing this feature reviewed and added. If this is abandoned by the author I can pull it down and try and push over the finish line |
|
No, we pushed back on this, and instead now expect CNIs to not add random taints that people have to work around in other projects. RKE2's packaged cilium now disables this: #151 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows chart resources to specify additional tolerations.
The use case for this is making sure that CNI charts can be updated even when you accidentally deploy a chart config change that breaks the CNI itself.