[omer-tmakers]

What

Upgrade Keda and GPU components versions

Why

To have the latest working version of K3D using GPU

Implications

[Copilot]

Pull Request Overview

Upgrades GPU components and Keda versions to provide better CUDA support in k3d with latest working versions.

• Updates K3s version from v1.28.8-k3s1 to v1.31.7-k3s1
• Upgrades CUDA base image from 12.4.1-base-ubuntu22.04 to 12.8.1-base-ubuntu24.04
• Updates NVIDIA device plugin from v0.15.0-rc.2 to v0.17.1

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
install_gpu_drivers_server.sh	New script for installing GPU drivers on Ubuntu 24.04 server
device-plugin-daemonset.yaml	Updates NVIDIA device plugin image version
build.sh	Enhanced build script with improved error handling and updated versions
Dockerfile	Multi-stage Dockerfile improvements with updated CUDA/K3s versions
cuda.md	Documentation updates reflecting new versions and server preparation

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

This code block duplicates the NVIDIA toolkit installation steps that already appear earlier in the script (lines 17-33). The duplicated code should be removed to avoid confusion and potential conflicts.

Suggested change

	# Add NVIDIA GPG key
	curl -s -L https://nvidia.github.io/libnvidia-container/gpgkey | \
	sudo gpg --dearmor -o /usr/share/keyrings/nvidia-container-toolkit-keyring.gpg
	# Add repo using fake distribution
	curl -s -L https://nvidia.github.io/libnvidia-container/$distribution/libnvidia-container.list | \
	sed 's#deb https://#deb [signed-by=/usr/share/keyrings/nvidia-container-toolkit-keyring.gpg] https://#g' | \
	sudo tee /etc/apt/sources.list.d/nvidia-container-toolkit.list
	sudo apt-get update
	sudo apt-get install -y nvidia-container-toolkit
	sudo nvidia-ctk runtime configure --runtime=docker
	sudo systemctl restart docker

[Copilot]

The heading mentions 'Keda' but should be 'CUDA' based on the context. This appears to be a typo as the section is about preparing a server for GPU/CUDA workloads, not Keda (Kubernetes Event-driven Autoscaling).

Suggested change

	## Preparing Server to run Keda
	## Preparing Server to run CUDA

[Copilot]

There's a typo in 'exmaple' which should be 'example'.

Suggested change

	To Create a Server that has all the drivers installed you can use exmaple script prepared for Ubuntu 24.04
	To Create a Server that has all the drivers installed you can use example script prepared for Ubuntu 24.04

[Copilot]

The 'less' package is listed twice in the same RUN command (lines 26 and 30), creating unnecessary duplication.

Suggested change

less \