Skip to content

fix: prevent crashes caused by null secret config#10

Merged
AndrejsPon00 merged 2 commits intomainfrom
fix-secret-data
Feb 25, 2026
Merged

fix: prevent crashes caused by null secret config#10
AndrejsPon00 merged 2 commits intomainfrom
fix-secret-data

Conversation

@AndrejsPon00
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issues with application startup when the configuration secret is empty or not yet populated. It allows health checks to proceed even with empty configuration, and modifies the Helm chart to preserve existing secret values during upgrades instead of overwriting them.

Changes:

  • Modified EmptyConfigMiddleware to allow /health endpoint to bypass empty configuration checks
  • Updated Helm secret template to use lookup function to preserve existing secret values during upgrades
  • Removed commented example configuration data from values.yaml

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
internal/middleware/empty_config.go Added bypass logic for health check endpoint when config is empty, enabling Kubernetes probes to succeed during initial startup
helm-charts/vlogxy/values.yaml Removed commented example configuration data, simplifying the values file
helm-charts/vlogxy/templates/secret.yaml Implemented secret preservation logic using lookup function to maintain existing config across Helm upgrades

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/middleware/empty_config.go Outdated
Comment thread internal/middleware/empty_config.go Outdated
Comment thread helm-charts/vlogxy/templates/secret.yaml
Comment thread internal/middleware/empty_config.go Outdated
Comment thread internal/middleware/empty_config.go Outdated
Comment thread helm-charts/vlogxy/templates/secret.yaml
@AndrejsPon00 AndrejsPon00 merged commit c0826db into main Feb 25, 2026
@AndrejsPon00 AndrejsPon00 deleted the fix-secret-data branch March 2, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants