fix: prevent crashes caused by null secret config#10
Merged
AndrejsPon00 merged 2 commits intomainfrom Feb 25, 2026
Merged
Conversation
denis-ryzhkov
approved these changes
Feb 25, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses issues with application startup when the configuration secret is empty or not yet populated. It allows health checks to proceed even with empty configuration, and modifies the Helm chart to preserve existing secret values during upgrades instead of overwriting them.
Changes:
- Modified EmptyConfigMiddleware to allow
/healthendpoint to bypass empty configuration checks - Updated Helm secret template to use
lookupfunction to preserve existing secret values during upgrades - Removed commented example configuration data from values.yaml
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| internal/middleware/empty_config.go | Added bypass logic for health check endpoint when config is empty, enabling Kubernetes probes to succeed during initial startup |
| helm-charts/vlogxy/values.yaml | Removed commented example configuration data, simplifying the values file |
| helm-charts/vlogxy/templates/secret.yaml | Implemented secret preservation logic using lookup function to maintain existing config across Helm upgrades |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.