fix bug happens with " and rewrite applescript to javascript#5
Open
pastak wants to merge 2 commits intojwalgran:masterfrom
Open
fix bug happens with " and rewrite applescript to javascript#5pastak wants to merge 2 commits intojwalgran:masterfrom
" and rewrite applescript to javascript#5pastak wants to merge 2 commits intojwalgran:masterfrom
Conversation
pastak
added a commit
to pastak/playing
that referenced
this pull request
Sep 5, 2015
pastak
added a commit
to pastak/playing
that referenced
this pull request
Sep 5, 2015
Author
|
I think improvement Apple Script is better than this PR. JAX is not supported before Yosemite. |
Owner
|
Thanks so much for rewriting the automation code in JS. I made a new |
Author
|
😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, this PR includes 2 changes. ( But, I think Rewriting is needed for BugFix )
First, I fixed bug that happens when track name or album name or artist name includes
"(ex:Don't say "Lazy"https://itunes.apple.com/jp/album/dont-say-lazy-ep/id311581360?l=en ).I tried fix on JS ( c18e2a3 ) but it's very dirty hack. So I had tried to fix AppleScript but I can't run on my Yosemite( I wonder why ).
Then I rewrite AppleScript to JavaScript(JAX). It all works same as Apple Script.
I want to merge it.
@jwalgran How do you think?