Add DashCam style recording for gif format.#99
Open
AmitRungta wants to merge 1 commit intojustinfrankel:mainfrom
Open
Add DashCam style recording for gif format.#99AmitRungta wants to merge 1 commit intojustinfrankel:mainfrom
AmitRungta wants to merge 1 commit intojustinfrankel:mainfrom
Conversation
In this version have added the option to retains just the last specified time of recording and ignore the inital recording when saving in gif format. This option is useful when recording hard to find cases and you just want to retain the last few seconds or recording with the case being simulated. In this have created a base class for encoder and from that class derived the gif_encoder and dashcam_encoder. gif_encoder remains mostly the same but with functions being transferred to the base class whereas in dashcam_encoder we are saving the scrren differences for the last desired time as memory bitmap and discard the older ones and recreate a complete gif file when the user closes the recording. This option is only available when saving as gif file and on windows system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this version have added the option to retains just the last specified time of recording and ignore the inital recording when saving in gif format. This option is useful when recording hard to find cases and you just want to retain the last few seconds or recording with the case being simulated.
In this have created a base class for encoder and from that class derived the gif_encoder and dashcam_encoder. gif_encoder remains mostly the same but with functions being transferred to the base class whereas in dashcam_encoder we are saving the scrren differences for the last desired time as memory bitmap and discard the older ones and recreate a complete gif file when the user closes the recording.
This option is only available when saving as gif file and on windows system.