rust: Reduce CPU time by ~20%#11
Open
jturcotte wants to merge 1 commit intojurihock:mainfrom
Open
Conversation
This reduces cache misses by having more data of the same bin available on the same cache line.
Owner
|
Nice, thanks! I'll take a closer look at it when I have more time... May I ask what type of CPU you are using? Is it Intel, AMD or Apple Silicon? |
Author
|
Sure, I ran this on an Intel i9-13900H. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I don't know if this is a change you'd want to integrate verbatim since it also needs to change the public API, but I thought that the findings are at least interesting to share.
The C++ implementation would likely get similar benefits from consolidating the per-bin data.