-
Notifications
You must be signed in to change notification settings - Fork 383
Add buildpack for pyproject.toml to configure container image #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
83b5f11
to
577cb1b
Compare
577cb1b implements a minimal working version. It was tested with https://github.com/rgaiacs/binder-examples-pyproject. Required changes before merge
Changes that can be done in another pull request
|
"""PATH="${KERNEL_PYTHON_PREFIX}/bin:$PATH" \\ | ||
pip install --no-cache-dir --editable . | ||
""", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do:
"""PATH="${KERNEL_PYTHON_PREFIX}/bin:$PATH" \\ | |
pip install --no-cache-dir --editable . | |
""", | |
"${KERNEL_PYTHON_PREFIX}/bin/python3 -m pip install --no-cache-dir --editable .", |
to be even more explicit than relying on $PATH?
All tests are passing after support to Python < 3.11 was dropped. |
I've got a PR that refactors the handling of runtime.txt |
because of tomllib.
since Python 3.9 is no longer supported as it does not have tomllib.
because now repo2docker requires Python >= 3.11 given the requirement of tomllib.
ad70986
to
974a559
Compare
I rebased this pull request and I made minor changes to reduce the code duplication. It need to be reviewed again. |
Related to #1427
This is not yet ready for review!The code is based on the Pipfile buildpack. We probably want to refactor some portions to avoid code duplication.