Update to use Maven 4 #560
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
reviewed
May 28, 2025
| @@ -9,8 +9,7 @@ | |||
|
|
|||
| <properties> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <maven.compiler.source>1.8</maven.compiler.source> | |||
| <maven.compiler.target>${maven.compiler.source}</maven.compiler.target> | |||
| <maven.compiler.release>17</maven.compiler.release> | |||
There was a problem hiding this comment.
Was this change required to make it work?
There was a problem hiding this comment.
It is required to no longer use the obsolete options - and prevent those warnings to be emitted:
Warning: bootstrap class path not set in conjunction with -source 8
Warning: source value 8 is obsolete and will be removed in a future release
Warning: target value 8 is obsolete and will be removed in a future release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test-drive Maven 4 with JUnit's sample projects.
This PR also prevents the following warnings to be emitted:
I hereby agree to the terms of the JUnit Contributor License Agreement.