Skip to content

Conversation

@mangelajo
Copy link
Member

@mangelajo mangelajo commented Sep 24, 2025

Summary by CodeRabbit

  • Documentation
    • Added a Maintainers Guide outlining end-to-end release procedures, including versioning, branch/tag workflows, multi-repo steps, release notes creation, and publishing guidance.
    • Updated contributing docs with a new section header before a code block to improve readability.
    • Expanded the contributing table of contents to include the Maintainers Guide for easier navigation.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 24, 2025

Walkthrough

Introduces a new Maintainers Guide at docs/source/contributing/maintainers.md and updates docs/source/contributing.md to reference it. Also inserts a “##” header before a documentation practices code block. The toctree update appears twice in contributing.md, duplicating the same addition.

Changes

Cohort / File(s) Summary
Contributing docs updates
docs/source/contributing.md
Added a “##” header before a documentation practices code block. Updated toctree to include contributing/maintainers.md. The toctree addition appears twice in the file.
New Maintainers Guide
docs/source/contributing/maintainers.md
Added a new guide describing release procedures, environment variables, branching/tagging workflows, multi-repo steps, release notes, package index triggers, and PyPI publishing notes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • raballew
  • bennyz
  • NickCao

Poem

A bunny hops through docs so bright,
Adds a guide for release night.
Toctrees sprout, two leaves the same—
“Maintain!” they whisper, name by name.
With tags and notes, we’re set to go—
Hop, ship, done—onward we flow! 🐇📜✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “Release process” succinctly captures the main change by focusing on the release process documentation being introduced. It directly relates to the new Maintainers Guide content and is clear enough for a teammate scanning history to understand the primary change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mangelajo mangelajo changed the base branch from release-process to main September 24, 2025 15:52
@netlify
Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for jumpstarter-docs ready!

Name Link
🔨 Latest commit ce2e0f8
🔍 Latest deploy log https://app.netlify.com/projects/jumpstarter-docs/deploys/68e80ecf4efb3b000858f657
😎 Deploy Preview https://deploy-preview-645--jumpstarter-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
docs/source/contributing/maintainers.md (1)

19-25: Remove the duplicate PYTHON_NEXT export.

The example block exports PYTHON_NEXT=0.8.0-dev twice (Lines 20 and 24). Dropping the duplicate avoids confusing maintainers who copy/paste the snippet.

 export VERSION_PYTHON=0.7.0rc1
 export PYTHON_NEXT=0.8.0-dev
 export VERSION_GO=0.7.0-rc1
 export RELEASE_BRANCH=release-0.7
-# the next version of python used as anchor for main branch versions with pip index
-export PYTHON_NEXT=0.8.0-dev
+# the next version of python used as anchor for main-branch versions with the pip index
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17cf5d2 and ce2e0f8.

📒 Files selected for processing (2)
  • docs/source/contributing.md (1 hunks)
  • docs/source/contributing/maintainers.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/source/contributing/maintainers.md

57-57: Dollar signs used before commands without showing output

(MD014, commands-show-output)


70-70: Dollar signs used before commands without showing output

(MD014, commands-show-output)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Redirect rules - jumpstarter-docs
  • GitHub Check: Header rules - jumpstarter-docs
  • GitHub Check: Pages changed - jumpstarter-docs
  • GitHub Check: pytest-matrix (ubuntu-24.04, 3.11)
  • GitHub Check: pytest-matrix (ubuntu-24.04, 3.13)
  • GitHub Check: pytest-matrix (ubuntu-24.04, 3.12)
  • GitHub Check: e2e

- Break up text with headers, lists, and code blocks
- Target both beginners and advanced users

##
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Replace the empty ## heading.

Line 80 contains a heading marker with no title, which renders as a blank section header in Sphinx/Markdown. Drop it or give it a meaningful label (e.g., ## Reference) before the toctree.

🤖 Prompt for AI Agents
In docs/source/contributing.md around line 80 there is an empty heading marker
("##") that renders a blank section header; replace that line with a meaningful
heading (for example "## Reference") or remove the marker entirely before the
toctree so the documentation renders correctly and the table of contents is not
disrupted.

```

If you wish to create a pre-release you can add the desired suffixes, but please note that go
and python use sighlty different naming conventions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix typo in documentation.

Line 15 reads “sighlty”; please correct it to “slightly” so the instructions stay professional.

🤖 Prompt for AI Agents
In docs/source/contributing/maintainers.md around line 15, fix the typo
"sighlty" by replacing it with the correct spelling "slightly" so the sentence
reads "...and python use slightly different naming conventions.".

### set the version you want to release
```console
export VERSION_PYTHON=0.7.0
export VERSION_GO=0.7.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do these mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants