-
Notifications
You must be signed in to change notification settings - Fork 18
Release process #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Release process #645
Conversation
WalkthroughIntroduces a new Maintainers Guide at docs/source/contributing/maintainers.md and updates docs/source/contributing.md to reference it. Also inserts a “##” header before a documentation practices code block. The toctree update appears twice in contributing.md, duplicating the same addition. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for jumpstarter-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/source/contributing/maintainers.md (1)
19-25: Remove the duplicatePYTHON_NEXTexport.The example block exports
PYTHON_NEXT=0.8.0-devtwice (Lines 20 and 24). Dropping the duplicate avoids confusing maintainers who copy/paste the snippet.export VERSION_PYTHON=0.7.0rc1 export PYTHON_NEXT=0.8.0-dev export VERSION_GO=0.7.0-rc1 export RELEASE_BRANCH=release-0.7 -# the next version of python used as anchor for main branch versions with pip index -export PYTHON_NEXT=0.8.0-dev +# the next version of python used as anchor for main-branch versions with the pip index
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/source/contributing.md(1 hunks)docs/source/contributing/maintainers.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/source/contributing/maintainers.md
57-57: Dollar signs used before commands without showing output
(MD014, commands-show-output)
70-70: Dollar signs used before commands without showing output
(MD014, commands-show-output)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Redirect rules - jumpstarter-docs
- GitHub Check: Header rules - jumpstarter-docs
- GitHub Check: Pages changed - jumpstarter-docs
- GitHub Check: pytest-matrix (ubuntu-24.04, 3.11)
- GitHub Check: pytest-matrix (ubuntu-24.04, 3.13)
- GitHub Check: pytest-matrix (ubuntu-24.04, 3.12)
- GitHub Check: e2e
| - Break up text with headers, lists, and code blocks | ||
| - Target both beginners and advanced users | ||
|
|
||
| ## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace the empty ## heading.
Line 80 contains a heading marker with no title, which renders as a blank section header in Sphinx/Markdown. Drop it or give it a meaningful label (e.g., ## Reference) before the toctree.
🤖 Prompt for AI Agents
In docs/source/contributing.md around line 80 there is an empty heading marker
("##") that renders a blank section header; replace that line with a meaningful
heading (for example "## Reference") or remove the marker entirely before the
toctree so the documentation renders correctly and the table of contents is not
disrupted.
| ``` | ||
|
|
||
| If you wish to create a pre-release you can add the desired suffixes, but please note that go | ||
| and python use sighlty different naming conventions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo in documentation.
Line 15 reads “sighlty”; please correct it to “slightly” so the instructions stay professional.
🤖 Prompt for AI Agents
In docs/source/contributing/maintainers.md around line 15, fix the typo
"sighlty" by replacing it with the correct spelling "slightly" so the sentence
reads "...and python use slightly different naming conventions.".
| ### set the version you want to release | ||
| ```console | ||
| export VERSION_PYTHON=0.7.0 | ||
| export VERSION_GO=0.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do these mean?
Summary by CodeRabbit