-
Notifications
You must be signed in to change notification settings - Fork 19
Add pre/post lease hooks #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kirkbrauer
wants to merge
24
commits into
main
Choose a base branch
from
add-hooks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,281
−153
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9accb01
Add pre/post lease hooks
kirkbrauer ed5f23c
Merge branch 'main' into add-hooks
kirkbrauer 64962be
Add enums and exporter status reporting
kirkbrauer 6e8b44f
Improve logging infrastructure
kirkbrauer c2aae20
Merge branch 'main' into add-hooks
kirkbrauer 8581946
Merge branch 'main' into add-hooks
kirkbrauer 0d7607a
Fix circular dependency in logging.py
kirkbrauer 1ede9a5
Merge branch 'main' into add-hooks
kirkbrauer b5de172
Update hook behavior to match spec
kirkbrauer 7581373
Improve hook error handling
kirkbrauer c85e583
Merge branch 'main' into add-hooks
kirkbrauer aa951a3
Add strongly-typed Protobuf and gRPC codegen and refactor exporter fo…
kirkbrauer fac4810
Merge branch 'main' into add-hooks
kirkbrauer c7ca1e5
Improve messaging and typing
kirkbrauer 4e4a42b
Finish refactoring the Exporter class and improve hooks handling
kirkbrauer aa13aea
Fix broken tests due to field name change and status not being correct
kirkbrauer d140613
Fix typing issues
kirkbrauer 3b71d7a
Fix controller registration issue
kirkbrauer cab55c9
Add status field to jmp admin get exporter
kirkbrauer cc44664
Fix lease status race condition causing E2E tests to fail
kirkbrauer 0cb3cab
Fix additional status update race conditions breaking E2E
kirkbrauer a129ff7
Fix unit test failures
kirkbrauer 6aa6a1f
Fix broken unit tests
kirkbrauer e0d3571
Merge branch 'main' into add-hooks
mangelajo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not your patches fault, but I hate this API, we need to improve it hehehe :D