-
Notifications
You must be signed in to change notification settings - Fork 4
Revised Endpoint message #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Tested in jumpstarter-dev/jumpstarter@97cc6b5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
proto/jumpstarter/v1/jumpstarter.proto (1)
133-138: Endpoint Schema Update: Field Reordering and Credential EnhancementsThe
Endpointmessage has been updated as follows:
- Certificate Field (line 135): The previously optional
certificatefield has been repositioned as field number 2 and is now required (i.e., theoptionalkeyword has been removed). This is a breaking change—please verify that all client and server implementations provide a valid certificate.- New Credential Fields (lines 136-137): Two new fields,
client_certificateandclient_private_key, have been added at positions three and four respectively to enhance endpoint authentication. Ensure that these fields are securely handled, validated, and documented in the client-side integrations.- Removal of Token Field: Although not visible in the current diff, note that the deprecated
tokenfield has been removed. Confirm that any external dependencies or integrations relying on the token are updated accordingly.
Summary by CodeRabbit