Add alternative_endpoints field to GetReportResponse for direct conne…

[NickCao]

…ctivity

Summary by CodeRabbit

• New Features
  • API responses now include multiple alternative endpoints, each offering optional certificate details for enhanced information delivery.

[coderabbitai]

Walkthrough

The pull request updates the proto definitions in proto/jumpstarter/v1/jumpstarter.proto. It introduces a new message type, Endpoint, which contains a required string endpoint, a required string token, and an optional string certificate. Additionally, a new repeated field alternative_endpoints of type Endpoint is added to the existing GetReportResponse message, enabling it to include multiple alternative endpoints.

Changes

File	Changes
proto/jumpstarter/.../jumpstarter.proto	- Added new message Endpoint with fields: endpoint (required string), token (required string), and certificate (optional string) - Added repeated field alternative_endpoints of type Endpoint in GetReportResponse

Poem

I’m a rabbit tapping my feet,
In proto fields, new endpoints meet.
A certificate spark, a string so fine,
Alternative paths in every line.
Hop along the code, bright and neat!
🐇✨

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

proto/jumpstarter/v1/jumpstarter.proto (1)

133-137: Addition of the Endpoint Message

The new Endpoint message has been defined appropriately with the required fields endpoint and token, and an optional field certificate for additional data. A minor consideration: in proto3, the optional modifier for scalar types requires explicit support (enabled via a flag) if you need presence tracking. Confirm that your project's protos are configured for this behavior. If not, you may consider removing the optional specifier if presence tracking isn’t needed.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2588c89 and 33c3f6e.

📒 Files selected for processing (1)

• proto/jumpstarter/v1/jumpstarter.proto (1 hunks)

🔇 Additional comments (1)

proto/jumpstarter/v1/jumpstarter.proto (1)

130-131: Addition of alternative_endpoints Field in GetReportResponse

The new repeated field alternative_endpoints is correctly appended as field number 4, following the existing fields in GetReportResponse. Ensure that downstream consumers of the GetReportResponse are updated to handle this new field as needed, and that any serialization/deserialization logic properly incorporates this change.

[mangelajo]

Nice, since you discover this self-signed cert during connection thorough the main jumpstarter-controller... you know you can trust it. you obtained it in a secure channel :D

And same for the token,

brilliant!