-
Notifications
You must be signed in to change notification settings - Fork 2
add checking of running container on each exporter host #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| package container | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
| "os/exec" | ||
| "strings" | ||
| ) | ||
|
|
||
| // ImageLabels represents the labels from a container image | ||
| type ImageLabels struct { | ||
| Version string | ||
| Revision string | ||
| } | ||
|
|
||
| // GetImageLabelsFromRegistry retrieves image labels from a registry using skopeo | ||
| func GetImageLabelsFromRegistry(imageURL string) (*ImageLabels, error) { | ||
| // Always add the docker:// prefix for skopeo | ||
| imageURL = "docker://" + imageURL | ||
|
|
||
michalskrivanek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| cmd := exec.Command("skopeo", "inspect", "--override-os", "linux", "--override-arch", "amd64", imageURL) | ||
| output, err := cmd.Output() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to inspect image %s with skopeo: %w", imageURL, err) | ||
| } | ||
|
|
||
| var imageInfo struct { | ||
| Labels map[string]string `json:"Labels"` | ||
| } | ||
|
|
||
| if err := json.Unmarshal(output, &imageInfo); err != nil { | ||
| return nil, fmt.Errorf("failed to parse skopeo output: %w", err) | ||
| } | ||
|
|
||
| // Get both label sets | ||
| jumpstarterVersion := imageInfo.Labels["jumpstarter.version"] | ||
| jumpstarterRevision := imageInfo.Labels["jumpstarter.revision"] | ||
| ociVersion := imageInfo.Labels["org.opencontainers.image.version"] | ||
| ociRevision := imageInfo.Labels["org.opencontainers.image.revision"] | ||
|
|
||
| // Use jumpstarter labels if both exist, otherwise fall back to OCI labels | ||
| var version, revision string | ||
| if jumpstarterVersion != "" && jumpstarterRevision != "" { | ||
| version = jumpstarterVersion | ||
| revision = jumpstarterRevision | ||
| } else { | ||
| version = ociVersion | ||
| revision = ociRevision | ||
| } | ||
|
|
||
| // Only return empty labels if BOTH version and revision are completely missing | ||
| // (neither jumpstarter nor OCI labels exist) | ||
| return &ImageLabels{ | ||
| Version: version, | ||
| Revision: revision, | ||
| }, nil | ||
| } | ||
|
|
||
| // GetRunningContainerLabels retrieves labels from a running container using podman inspect | ||
| func GetRunningContainerLabels(serviceName string) (*ImageLabels, error) { | ||
| cmd := exec.Command("podman", "inspect", "--format", | ||
| "{{index .Config.Labels \"jumpstarter.version\"}} {{index .Config.Labels \"jumpstarter.revision\"}}", | ||
| serviceName) | ||
| output, err := cmd.Output() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to inspect container %s: %w", serviceName, err) | ||
| } | ||
|
|
||
| parts := strings.Fields(strings.TrimSpace(string(output))) | ||
| if len(parts) < 2 { | ||
| return &ImageLabels{}, nil // Return empty labels if not found | ||
| } | ||
|
|
||
| return &ImageLabels{ | ||
| Version: parts[0], | ||
| Revision: parts[1], | ||
| }, nil | ||
| } | ||
|
|
||
| // CompareVersions compares two ImageLabels and returns true if they match | ||
| func (il *ImageLabels) Matches(other *ImageLabels) bool { | ||
| return il.Version == other.Version && il.Revision == other.Revision | ||
| } | ||
|
|
||
| // IsEmpty returns true if both version and revision are empty | ||
| func (il *ImageLabels) IsEmpty() bool { | ||
| return il.Version == "" && il.Revision == "" | ||
| } | ||
|
|
||
| // String returns a string representation of the image labels | ||
| func (il *ImageLabels) String() string { | ||
| if il.IsEmpty() { | ||
| return "no version info" | ||
| } | ||
| return fmt.Sprintf("version=%s revision=%s", il.Version, il.Revision) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this line since we have the other?