Update jump-api pr #294
Merged
Update jump-api pr #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jg/jumpapi #294 +/- ##
==============================================
- Coverage 89.10% 88.70% -0.41%
==============================================
Files 16 16
Lines 1992 2054 +62
==============================================
+ Hits 1775 1822 +47
- Misses 217 232 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joaquimg
commented
Jul 21, 2025
Comment on lines
+610
to
613
| # TODO check ci.value's | ||
| idx = model.cache.dual_mapping[ci.value] | ||
| return model.forw_grad_cache.dual_Δs[idx] | ||
| catch |
There was a problem hiding this comment.
@andrewrosemberg, this way of getting the map does not seem to match perfectly with the one below
andrewrosemberg
pushed a commit
that referenced
this pull request
Aug 20, 2025
* prepare more tests * sketch * temp examples * remove printing * remove printing * remove duplicatie def * move definition * format * format * simplify conic model * force nlp on nlp tests * fix param tests * cleanup parameter usage * remove code * cleanup usage of parameters * format * add temp dep * format * add temp dep * fix PSDSquare * temp fix for tests * format
joaquimg
added a commit
that referenced
this pull request
Aug 20, 2025
* initial sketch * rm method * add JuMP API and test it * add diff_model test * Fix conic error (#284) * fix conic error * use jump psd problem * [docs] update to Documenter@1 (#286) * [docs] update to Documenter@1 * Update * update * format * Pass attributes through Objective.FunctionConversionBridge (#287) * Pass attributes through Objective.FunctionConversionBridge * Fix * add test * fix tol * fix test * add reverse test --------- Co-authored-by: joaquimg <[email protected]> * bump POI * cleanup --------- Co-authored-by: Oscar Dowson <[email protected]> Co-authored-by: Benoît Legat <[email protected]> Co-authored-by: joaquimg <[email protected]> * fix parameters support * Update jump-api pr (#294) * prepare more tests * sketch * temp examples * remove printing * remove printing * remove duplicatie def * move definition * format * format * simplify conic model * force nlp on nlp tests * fix param tests * cleanup parameter usage * remove code * cleanup usage of parameters * format * add temp dep * format * add temp dep * fix PSDSquare * temp fix for tests * format * Improve name handling, cleanup parameter error messages, remove slack * re-enable constraint names * Integrate new POI (#302) * integrate new POI * remove test * rm adhoc pkg add * fix docs * add POI test and docs * rm test_solve_conflict * format * add parameter in cone test * add back name constraint vect * Update Project.toml --------- Co-authored-by: Joaquim <[email protected]> * add tests * format --------- Co-authored-by: Andrew Rosemberg <[email protected]> Co-authored-by: Oscar Dowson <[email protected]> Co-authored-by: Benoît Legat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.