fix: parse post content before sending notification#124
Open
cryptoethic wants to merge 2 commits intojulianlam:masterfrom
Open
fix: parse post content before sending notification#124cryptoethic wants to merge 2 commits intojulianlam:masterfrom
cryptoethic wants to merge 2 commits intojulianlam:masterfrom
Conversation
Owner
|
This would cause issues in the notifications themselves (in NodeBB), as they're not meant to take raw html. There might be a different hook you can use for markdown parsing for emails only .. |
Author
|
Okay. What about SocketHelpers.sendNotificationToPostOwner from core src/socket.io/helpers.js It is from where I took inspiration |
Author
|
I believe it can be attached to filter:email.params (checking if type of notification type is mention and then replacing body with post.parsePost) But what about other notifications types that parse post content before firing. I haven't noticed them working incorrectly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue I have created on NodeBB repo: NodeBB/NodeBB#8358
Parse post content before sending notification