Fix for menu Issues with dynamic switching between contentResolver and contextProvider client#6
Open
geniusgeek wants to merge 9 commits intojuleswhite:masterfrom
Open
Fix for menu Issues with dynamic switching between contentResolver and contextProvider client#6geniusgeek wants to merge 9 commits intojuleswhite:masterfrom
geniusgeek wants to merge 9 commits intojuleswhite:masterfrom
Conversation
Collaborator
|
There are an enormous number of changes here -- too many to commit without an extensive review. Can you please summarize the key things you're trying to accomplish with these commits? Thanks, Doug |
Author
|
The main issue is that switching between the external polymorphisized implementation of HobitOps does not work as expected. It still uses the implementation of contentResolver even though contentProviderClient is selected. Also the menu click implementation does not follow the pattern in Android which overrides onOptionsItemSelected |
tt511-d
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the issues relating to switching between the external polymorphisized implementation of HobitOps using menu and other cleanup in code