Added exception handling and logging for video service failures#15
Open
MonteCreasor wants to merge 4 commits intojuleswhite:masterfrom
Open
Added exception handling and logging for video service failures#15MonteCreasor wants to merge 4 commits intojuleswhite:masterfrom
MonteCreasor wants to merge 4 commits intojuleswhite:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where the video service fails due to an exception, or when the actual connection fails, the application would terminate with an unhandled exception error. The added try/catch blocks prevent this from happening and also provide some meaningful Log.w() feedback that describe the exceptions to implementors.
Also added a fix that was causing the floating action button to not appear on the bottom right in portrait mode (on Nexus 6 / Lollipop 5.1.1). The fix was to simply not set margins when building the button. I left the .withMargins(0,0,0,0) for illustrative purposes only.