Gui tests#216
Conversation
… imported in the files committed above
… imported in the files committed above
… imported in the files committed above
… imported in the files committed above
…to the config.yaml file
|
Thanks for doing this @ludivintchokote, this is great! I hate to say it, but this PR seems to have not been created from a clean properly sync'ed main. Also, this is a pretty big job. I suggest that we maybe break it down into small PRs and get the merged separately to make the code review a bit easier. Also, none of your tests are passing. Are you running them locally to test before making the PR? |
|
Yeah to test first put the test file in the code folder and run the test.
Locally that's what I did. To test it directly from the test file raised
import issues. I'm trying to figure a way to fix the import error I'm
receiving
…On Wed, Jan 29, 2025, 13:41 Simon Billinge ***@***.***> wrote:
Thanks for doing this @ludivintchokote
<https://github.com/ludivintchokote>, this is great!
I hate to say it, but this PR seems to have not been created from a clean
properly sync'ed main.
Also, this is a pretty big job. I suggest that we maybe break it down into
small PRs and get the merged separately to make the code review a bit
easier.
Also, none of your tests are passing. Are you running them locally to test
before making the PR?
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNJCXPEX2K24PA6KYQAG7RD2NDD6RAVCNFSM6AAAAABWBCLNTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRRGUZTGNJZGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Oh! What should I do each time I'm creating a new branch from the main
branch? When creating it tells me it's synced with the main. Perhaps
there's something I'm not getting right
On Wed, Jan 29, 2025, 18:01 Ludivin Tchokote ***@***.***>
wrote:
… Yeah to test first put the test file in the code folder and run the test.
Locally that's what I did. To test it directly from the test file raised
import issues. I'm trying to figure a way to fix the import error I'm
receiving
On Wed, Jan 29, 2025, 13:41 Simon Billinge ***@***.***>
wrote:
> Thanks for doing this @ludivintchokote
> <https://github.com/ludivintchokote>, this is great!
>
> I hate to say it, but this PR seems to have not been created from a clean
> properly sync'ed main.
>
> Also, this is a pretty big job. I suggest that we maybe break it down
> into small PRs and get the merged separately to make the code review a bit
> easier.
>
> Also, none of your tests are passing. Are you running them locally to
> test before making the PR?
>
> —
> Reply to this email directly, view it on GitHub
> <#216 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BNJCXPEX2K24PA6KYQAG7RD2NDD6RAVCNFSM6AAAAABWBCLNTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRRGUZTGNJZGM>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Let's test your setup. Please could you type "git remote -v" and then "git checkout main" and then "git pull upstream main" and paste a screenshot of what your terminal looks like without losing anything. |
|
Please find the output below
Here's the output |
|
@ludivintchokote ok, great everything seems to be correctly connected. Please can you now type |
|
this is what my main looks like: |
|
Here's the output of the git log
…On Wed, Jan 29, 2025, 20:35 Simon Billinge ***@***.***> wrote:
@ludivintchokote <https://github.com/ludivintchokote> ok, great
everything seems to be correctly connected. Please can you now type git
log. Let's see if there are any accidental commits to your local main.....
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNJCXPHLMLK46J3BP52BF3L2NEUQBAVCNFSM6AAAAABWBCLNTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRSGY3DINRRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
thanks @ludivintchokote but I don't see the output.... |
|
Here's the image
…On Wed, Jan 29, 2025, 21:05 Simon Billinge ***@***.***> wrote:
Here's the output of the git log
… <#m_4052999262151618294_>
On Wed, Jan 29, 2025, 20:35 Simon Billinge *@*.*> wrote: @ludivintchokote
<https://github.com/ludivintchokote> https://github.com/ludivintchokote
<https://github.com/ludivintchokote> ok, great everything seems to be
correctly connected. Please can you now type git log. Let's see if there
are any accidental commits to your local main..... — Reply to this email
directly, view it on GitHub <#216 (comment)
<#216 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BNJCXPHLMLK46J3BP52BF3L2NEUQBAVCNFSM6AAAAABWBCLNTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRSGY3DINRRGI
<https://github.com/notifications/unsubscribe-auth/BNJCXPHLMLK46J3BP52BF3L2NEUQBAVCNFSM6AAAAABWBCLNTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRSGY3DINRRGI>
. You are receiving this because you were mentioned.Message ID: @.*>
thanks @ludivintchokote <https://github.com/ludivintchokote> but I don't
see the output....
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNJCXPEGLZMKOEWJSKYA3D32NEX7VAVCNFSM6AAAAABWBCLNTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRSG4ZDKOJUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
this is what I see when I click on that image link, I don't see the git log....: |
|
Sorry here is the output |
|
|
|
ok @ludivintchokote everything looks ok. Please can you try and make a new branch off of main and do some edits and make a PR and let's see if it clean or has extra commits for some reason. |
3 participants
Closes #191