Add transparency feature #164
Conversation
|
Why is this PR not merged? |
|
I would prefer a more complete approach. If we enable transparency it would have its own slider from 0 to 100. Maybe 50% for you would not mean transparent for other users. |
kadamski
force-pushed
the
transparency
branch
3 times, most recently
from
d64e183 to
f2b703c
Compare
|
Ok, it took me a moment to make linter workflow happy. I didn't trigger it earlier so I didn't know it exists. I have added a new commit that implements configuration of transparency as you requested. I have left the previous commit as is with only tiny fix in src/config.h line 290 where I'm using correct default value define now. I didn't want you to have to review everything again and I think the first commit is somewhat self contained. But feel free to squash both commits if you prefer it that way. It looks like this: |
|
Thank you for this @kadamski it's pretty good. The only thing is that you forgot to update the README with the new config and tooling support (very close to what you did with the .scd file). |
It is sometimes better if the drawing is not fully covering the picture but is semi-transparent. This patch adds a simple button to enable transparency. When this button is enabled, everything will be drawn with 50% alpha channel.
This commit adds UI elements and config option for configuring the transparency value. The default value is 50% but it can be changed in the 5% - 95% range in 10% steps.
The previous commit added this info to the man page but README was not updated. Lets fix this.
|
@jtheoof thank you for reviewing that. I force-pushed the rebased commits to my branch and added a small one on top that syncs the info in man page to the README file. If there's anything more to do, let me know. |
|
Thanks ! |
It is sometimes better if the drawing is not fully covering the picture but is semi-transparent. This patch adds a simple button to enable transparency. When this button is enabled, everything will be drawn with 50% alpha channel.