Feat: add plugin-translate#3574
Conversation
|
|
@courtney-bryce-hilton this looks great - very exciting! |
|
Thanks Becky! Feel free to edit the PR directly if that's easier. Whatever you'd prefer. |
| "dependencies": { | ||
| "regenerator-runtime": "^0.14.0" | ||
| }, | ||
| "version": "7.28.2", |
There was a problem hiding this comment.
babel/runtime updated because of it's listed as an i18next dependency with version specified as "^7.27.6".
| dropdownEl.style.fontSize = "14px"; | ||
| dropdownEl.style.fontFamily = "Open Sans, Arial', sans-serif"; | ||
| dropdownEl.style.padding = "4px"; |
There was a problem hiding this comment.
Added this to match the style used in the only other select elements I could find in jsPsych (other than in the survey plugin), which are written as inline style in the initialize-camera and initialize-microphone plugins. This should probably factored out of all of the plugins and moved into the jspsych.css file as a jspsych-dropdown class. Do we want to do that in this PR?
There was a problem hiding this comment.
Yea, that'd be a good idea I think.
Actually I had left the styling for the dropdown blank because I wasn't sure what default jspsych styling to apply and I couldn't find anything in jspsych.css for it.
Should we just create a jspsych-dropdown class or something?
There was a problem hiding this comment.
Sounds good to me! We should probably wait for a 👍 from @jodeleeuw because the CSS change will require a jspsych core release. And we'll need to tell people to use the translate plugin with that upcoming jsPsych core version rather than just v8 (either make it a formal dependency or just recommend it in the docs).
2 participants
This PR adds my initial pass at putting together the jsPsychTranslate plugin to facilitate multilingual experiments, based on discussions with Becky and Josh (as well as Melissa and Sam; as part of the POSE project).