add tests on resume validation #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Walkthrough
The changes update the crate name in Cargo.toml, expand the README with usage and validation instructions, and enhance the `Resume` struct and its related types to support validation using the `serde_valid` crate. The `Resume` struct's `basics` field is now optional, and validation attributes are added throughout. New validation tests are introduced.
## Changes
| File(s) | Change Summary |
|----------------------------------------------|-----------------------------------------------------------------------------------------------------|
| Cargo.toml | Package name changed from `json-resume` to `json-resume-serde`. |
| README.md | Expanded with usage instructions and validation examples using `serde_valid`. |
| src/resume.rs | `basics` field made optional; `#[validate]` added to all fields; new tests for validation added. |
| src/resume/interest.rs<br>src/resume/language.rs<br>src/resume/reference.rs<br>src/resume/skill.rs | Added `Validate` trait derive to `Interest`, `Language`, `Reference`, and `Skill` structs. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant Resume
participant serde_valid
User->>Resume: Construct or deserialize Resume instance
User->>Resume: Call .validate()
Resume->>serde_valid: Perform validation on all fields
serde_valid-->>Resume: Return validation result
Resume-->>User: Success or validation errorsEstimated code review effort3 (30–60 minutes) Possibly related PRs
Poem
|
Lab3ss
force-pushed
the
test_resume_validation
branch
from
d76f6fb to
da12495
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation
Tests
Chores