Skip to content

Latent filter #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 94 commits into
base: master
Choose a base branch
from
Draft

Latent filter #1

wants to merge 94 commits into from

Conversation

jsonBackup
Copy link
Owner

No description provided.

huchenlei and others added 29 commits June 27, 2024 09:13
…omfyanonymous#3895)

* Add linux integration test.

* Fix directory path.

* Add paths ignore.

* Fix conda env directory path.
Still missing the node to properly use it.
* Fix auto queue

* Detect added nodes via search

* Fix loading workflows

* Add button click style
The old _pp ones will be updated automatically to the regular ones with 2x
the cfg.

My fault for not checking what the "_pp" samplers actually did.
* Create CONTRIBUTING.md

* Add feature-request channel link.

* Remove discord links for channels.
* Bumping GitHub Actions versions

* Using LZMA2 for 7zip compression in Windows packaging
This change includes corrections for several spelling errors in the
documentation of example_node.py.example file.

These were previously raised by comfyanonymous#3157, but they missed a few.
* Add --no-custom-node cmd flag

* nit
…overwrite not specified (comfyanonymous#3472)

* Fix to comfyanonymous#3465. Prevent the, resaving of duplicate images if overwrite not specified

This is a fix to comfyanonymous#3465 

Adds function compare_image_hash to do a sha256 hash comparison between an uploaded image and existing images with matching file names. 

This changes the behavior so that only images having the same filename that are actually different are saved to input, existing images are instead now opened instead of resaved with increment. 

Currently, exact duplicates with the same filename are resave saved with an incremented filename in the format:

<filename> (n).ext 

with the code: 

```
while os.path.exists(filepath): 
                        filename = f"{split[0]} ({i}){split[1]}"
                        filepath = os.path.join(full_output_folder, filename)
                        i += 1
```

This commit changes this to: 

```
while os.path.exists(filepath): 
                        if compare_image_hash(filepath, image):
                            image_is_duplicate = True
                            break
                        filename = f"{split[0]} ({i}){split[1]}"
                        filepath = os.path.join(full_output_folder, filename)
                        i += 1
```

a check for if image_is_duplicate = False is done before saving the file. 

Currently, if you load the same image of a cat named cat.jpg into the LoadImage node 3 times, you will get 3 new files in your input folder with incremented file names.

With this change, you will now only have the single copy of cat.jpg, that will be re-opened instead of re-saved. 

However if you load 3 different images of cats named cat.jpg, you will get the expected behavior of having:
cat.jpg
cat (1).jpg
cat (2).jpg

This saves space and clutter. After checking my own input folder, I have 800+ images that are duplicates that were resaved with incremented file names amounting to more than 5GB of duplicated data.

* fixed typo in expression
comfyanonymous and others added 29 commits July 12, 2024 15:25
You can load model weights in diffusers format using the UNETLoader node.
* Fix send to workflow
Fix center align of close workflow dialog
Better support for elements around canvas

* More resilent to extra elements added to body
There was an issue when only the class type of a node changed with all the
inputs staying the same.
…ymous#3897)

* Add frontend manager

* Add tests

* nit

* Add unit test to github CI

* Fix path

* nit

* ignore

* Add logging

* Install test deps

* Remove 'stable' keyword support

* Update test

* Add web-root arg

* Rename web-root to front-end-root

* Add test on non-exist version number

* Use repo owner/name to replace hard coded provider list

* Inline cmd args

* nit

* Fix unit test
…ent (comfyanonymous#3947)

* cli_args: Add --duplicate-check-hash-function.

* server.py: compare_image_hash configurable hash function

Uses an argument added in cli_args to specify the type of hashing to default to for duplicate hash checking.  Uses an `eval()` to identify the specific hashlib class to utilize, but ultimately safely operates because we have specific options and only those options/choices in the arg parser.  So we don't have any unsafe input there.

* Add hasher() to node_helpers

* hashlib selection moved to node_helpers

* default-hashing-function instead of dupe checking hasher

This makes a default-hashing-function option instead of previous selected option.

* Use args.default_hashing_function

* Use safer handling for node_helpers.hasher()

Uses a safer handling method than `eval` to evaluate default hashing function.

* Stray parentheses are evil.

* Indentation fix.

Somehow when I hit save I didn't notice I missed a space to make indentation work proper.  Oops!
* support clip-vit-large-patch14-336

* support clip-vit-large-patch14-336
Move other unet model_patches nodes to model_patches/unet section.
* LoadAudio restores file value from workflow

* use onAfterGraphConfigured

* Don't use anonnymous function
It is based on: https://arxiv.org/abs/2407.12173

Add "beta" to the list of schedulers and the BetaSamplingScheduler node.
* Fix for isLittleEndian flag in parseExifData.

* Add break after reading first exif chunk in getWebpMetadata.
* Add timestamp to execution messages

* Add execution_end message

* Rename to execution_success
…4078)

* Supress frontend exception on unhandled message type

* nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.