Open
Conversation
Collaborator
|
+1 for platform-agnostic keybindings |
Owner
|
Agree that |
Collaborator
|
I noticed that they keybinding-resolver package uses these CSS classes to do platform-specific bindings: I wonder if we could do something similar? |
Author
I hope to be able to restore this, but right now it conflicts with a whole slew of keybindings in Atom on the Mac.
Owner
|
I'm going to address this in #66. Would you mind rebasing this PR on that branch? I'll merge it there and probably make a bunch of changes for Windows and Mac, as well. |
jsmecham
reviewed
Feb 12, 2018
keymaps/terminal.json
Outdated
| "alt-shift-t": "terminal:open" | ||
| }, | ||
| ".platform-win32 terminal-view": { | ||
| "ctrl-c": "terminal:copy", |
Owner
There was a problem hiding this comment.
I don't think we want to bind to Ctrl-C on Windows, as that's a standard shortcut for interrupting a program when running in a terminal.
Author
82f753c to
e3f6bc6
Compare
Author
|
What's the status of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add alt-shift-t keybinding to open terminal.
It allows non mac user to open terminal with keybinding.
It could help with #6 if we remove cmd-shift-t.