Skip to content

fix: PDF/A-3 metadata and ICC profile validation errors #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jslno merged 1 commit into from
Feb 7, 2026
+38 −6
Merged

fix: PDF/A-3 metadata and ICC profile validation errors #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/node-zugferd/src/document/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ export const createDocumentFactory =
metadata.modifyDate ??= metadata.createDate;

let pdfDoc =
pdf instanceof PDFDocument ? pdf : await PDFDocument.load(pdf);
pdf instanceof PDFDocument
? pdf
: await PDFDocument.load(pdf, { updateMetadata: false });

ctx.logger.debug(
`[${embedInPdf.name}] Attaching ${colors.bright}${profile.documentFileName}${colors.reset}`,
Expand Down Expand Up @@ -122,7 +124,7 @@ export const createDocumentFactory =
}

ctx.logger.debug(`[${embedInPdf.name}] Saving PDF`);
return await pdfDoc.save();
return await pdfDoc.save({ useObjectStreams: false });
};

return {
Expand Down
38 changes: 34 additions & 4 deletions packages/node-zugferd/src/formatter/pdf/formatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,33 @@ export const addPdfMetadata = (
"rdf:li": metadata.now.toISOString(),
},
},
...(metadata.title
? {
"dc:title": {
"rdf:Alt": {
"rdf:li": {
"@xml:lang": "x-default",
"#": metadata.title,
},
},
},
}
: {}),
...(metadata.subject
? {
"dc:description": {
"rdf:Alt": {
"rdf:li": {
"@xml:lang": "x-default",
"#": metadata.subject,
},
},
},
}
: {}),
"dc:creator": {
"rdf:Seq": {
"rdf:li": metadata.creator,
"rdf:li": metadata.author || metadata.creator,
},
},
},
Expand Down Expand Up @@ -151,7 +175,7 @@ export const addPdfMetadata = (
},
{
"@xmlns:fx": "urn:factur-x:pdfa:CrossIndustryDocument:invoice:1p0#",
"@xmlns:about": "",
"@rdf:about": "",
"fx:DocumentType": metadata.facturX.documentType,
"fx:DocumentFileName": metadata.facturX.documentFileName,
"fx:Version": metadata.facturX.version,
Expand All @@ -167,10 +191,15 @@ export const addPdfMetadata = (
`[${addPdfMetadata.name}] Generated XMP length: ${colors.bright}${xmp.length}${colors.reset}`,
);

const metadataStream = pdfDoc.context.stream(xmp, {
// Encode XMP as proper UTF-8 bytes before creating the stream.
// The original code passed the JS string directly with Length: xmp.length,
// but JS .length counts UTF-16 code units, not bytes. The \uFEFF BOM in
// the xpacket header is 1 JS char but 3 UTF-8 bytes, causing Length to
// be 2 bytes too short, which made PDF/A validators unable to read the XMP.
const xmpBytes = new TextEncoder().encode(xmp);
const metadataStream = pdfDoc.context.stream(xmpBytes, {
Type: "Metadata",
Subtype: "XML",
Length: xmp.length,
});

const metadataStreamRef = pdfDoc.context.register(metadataStream);
Expand Down Expand Up @@ -274,6 +303,7 @@ export const addPdfICC = (ctx: InternalContext, pdfDoc: PDFDocument) => {
ctx.logger.debug(`[${addPdfICC.name}] Adding ICC profile`);
const profile = base64ToUint8Array(COLOR_PROFILE);
const profileStream = pdfDoc.context.stream(profile, {
N: 3, // Number of color components (RGB = 3), required by PDF/A validators
Length: profile.length,
});
const profileStreamRef = pdfDoc.context.register(profileStream);
Expand Down
Loading