Limit to 1,000 levels of nested parentheses (closes #38) - #39
Open
kemitchell wants to merge 1 commit into
Open
kemitchell wants to merge 1 commit into
kemitchell wants to merge 1 commit into
Conversation
Add an arbitrary 1,000-level limit to the nesting of parenthentical grounds in parsed SPDX expessions.
Member
Author
|
@ljharb could I ask if you have any concerns about this PR, which implements a 1,000-level limit on nesting of parentheses in SPDX expressions? This was easy to implement, and I'd be extremely surprised to find anyone's nesting a thousand parentheses in practice. But I've never merged a patch like this before, and I still wonder whether it really needs to be "fixed". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an arbitrary 1,000-level limit to the nesting of parenthentical
grounds in parsed SPDX expessions.