Add IDLHarness for interface tests #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebmaster
force-pushed
the
feature/idl-tests
branch
from
89117e5 to
93e26f3
Compare
We just test that we always expose the interfaces in the sandbox.
Sebmaster
force-pushed
the
feature/idl-tests
branch
from
93e26f3 to
570d8d3
Compare
ExE-Boss
reviewed
Feb 17, 2020
Comment on lines
+28
to
+37
| return vm.runInContext( | ||
| `(() => { | ||
| let exports = {}; | ||
| const module = { exports }; | ||
| (() => {${src}})(); | ||
| return module.exports; | ||
| })();`, | ||
| sandbox, | ||
| { filename: resolved, lineOffset: 5, columnOffset: 16 } | ||
| ); |
There was a problem hiding this comment.
It might be better to use vm.compileFunction(…) here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally gets us some behaviour-based tests in this repo instead of relying on manually checked snapshots.