Add ability to validate Link and Embedded url #1378
+151
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| heightValid, | ||
| widthValid, | ||
| } = this.state; | ||
| console.log('heightValid', heightValid); |
| " component: undefined,\n" + | ||
| " popupClassName: undefined,\n" + | ||
| " embedCallback: undefined,\n" + | ||
| " embedValidator: undefined,\n" + |
There was a problem hiding this comment.
linkValidator field is missing in this file
sebmeister2077
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for providing a great library @jpuri
I needed the ability to validate the links so I have created this PR to add config options to validate the urls input for Link and Embedded
linkValidatorconfig options to provide functions to validate Link targetembedValidatorconfig options to provide functions to validate Embedded urlThis is partly based on #355, however it does not provide "allowRelative" link functionality nor prepends links with 'https://'. Both should be possible with a combination of the new
linkValidatorand the existinglinkCallbackPossibly related to #483