Make XML generator class overridable#9
Open
davidfischer-ch wants to merge 2 commits into
Open
Conversation
Owner
|
@davidfischer-ch thanks! A small test and update the docs would make this even better. |
Author
|
Sure, I will ! |
Collaborator
|
@davidfischer-ch - stil interested in making those small changes so we can merge this?
|
Author
|
Hello, Unfortunately I didn't have time to do so, but this "design pattern" is so common in the Python world ... Is it really needed to write test and doc? Thanks. |
|
Hello :) really want to push this PR. I'm pretty much at the same position and need to override the Is it possible to support you on brining this PR fast into master? :) |
jkblume
approved these changes
Jul 16, 2018
jkblume
left a comment
There was a problem hiding this comment.
very tiny and neat change, with good effort
Author
|
Hello, I just resolved the conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.