Skip to content

Make XML generator class overridable#9

Open
davidfischer-ch wants to merge 2 commits into
jpadilla:masterfrom
CloudNcodeInc:master
Open

Make XML generator class overridable#9
davidfischer-ch wants to merge 2 commits into
jpadilla:masterfrom
CloudNcodeInc:master

Conversation

@davidfischer-ch
Copy link
Copy Markdown

No description provided.

@jpadilla
Copy link
Copy Markdown
Owner

@davidfischer-ch thanks! A small test and update the docs would make this even better.

@davidfischer-ch
Copy link
Copy Markdown
Author

Sure, I will !

@kyleobrien91
Copy link
Copy Markdown
Collaborator

@davidfischer-ch - stil interested in making those small changes so we can merge this?

  • add a test
  • add some coverage about this in the documentation

@davidfischer-ch
Copy link
Copy Markdown
Author

Hello,

Unfortunately I didn't have time to do so, but this "design pattern" is so common in the Python world ... Is it really needed to write test and doc?

Thanks.

@jkblume
Copy link
Copy Markdown

jkblume commented Jul 16, 2018

Hello :)

really want to push this PR. I'm pretty much at the same position and need to override the short_empty_elements flag on XMLGenerator initialization.

Is it possible to support you on brining this PR fast into master? :)

Copy link
Copy Markdown

@jkblume jkblume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very tiny and neat change, with good effort

@davidfischer-ch
Copy link
Copy Markdown
Author

Hello,

I just resolved the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants