chore: Add clippy lints and fix violations - #6
Merged
Conversation
New lints: - unwrap_used: complements existing expect_used; prevents .unwrap() in library code - wildcard_enum_match_arm: complements exhaustive_enums; forces explicit variant handling instead of _ catch-alls - missing_errors_doc: enforces # Errors sections on public Result-returning fns - missing_panics_doc: enforces # Panics sections where applicable - redundant_else: removes else after blocks that already return/break Fixes: - Add unwrap_used to test module expect lists (alongside existing expect_used) - Expand wildcard match arms in jwks.rs to list variants explicitly - Replace wildcard match in pages.rs error formatting with if-let - Replace match/panic patterns in page tests with assert!(matches!(...)) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New lints:
library code
variant handling instead of _ catch-alls
Fixes:
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com