Cleanup: prune .env, name project, add compose-validate CI#35
Conversation
- .env.example: remove ~dozen vars no service consumes (OPENVPN_*, DOCKER_INFLUXDB_*, RADARR_*/SONARR_* URLs/keys, EMAIL/PASSWORD, HTTP_*, DOMAIN*, TRANSMISSION_USERNAME/PASSWORD, PLEX_ADVERTISE_IP, PLEX_TOKEN, TELEGRAF_CFG_PATH, the bare PATH= line). Group the rest by service with brief comments. Real values must be filled in, not just rely on placeholders. - docker-compose.yml: add top-level `name: autoplexx` so `docker compose` commands aren't sensitive to the directory name when running outside this checkout. - prometheus/prometheus.yml -> docs/prometheus.example.yml. There is still no `prometheus` service in compose; the rename makes its example-only status obvious. - New workflow .github/workflows/compose-validate.yml runs `docker compose config` on every PR that touches compose or .env.example, matching the validation step the CONTRIBUTING guide tells authors to run locally. - CLAUDE.md: update env-var contract (no more "documented but unused" category) and point at the new prometheus path. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR refactors the environment template to include only essential configuration variables for the active stack, updates documentation to clarify the new contract, adds a Docker Compose validation workflow, and defines the project name. Obsolete service credentials and placeholder variables are removed from ChangesConfiguration Stack Refactor
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
A pass of low-risk repo hygiene now that the bigger refactors have landed:
.env.example— remove the ~dozen vars no service indocker-compose.ymlactually reads (OPENVPN_*,DOCKER_INFLUXDB_*,RADARR_URL/RADARR_API_KEY,SONARR_URL/SONARR_API_KEY,EMAIL,PASSWORD,HTTP_USERNAME/HTTP_PASSWORD,DOMAIN/DOMAINNAME,TRANSMISSION_USERNAME/TRANSMISSION_PASSWORD,PLEX_ADVERTISE_IP,PLEX_TOKEN,TELEGRAF_CFG_PATH, and the lonelyPATH=line). Group the rest by service with brief comments. This is what tripped up the user in discussion #4.docker-compose.yml— add top-levelname: autoplexxso the project name is stable regardless of the directory the file is invoked from.prometheus/prometheus.yml→docs/prometheus.example.yml— there's still noprometheusservice in compose; the rename makes the example-only status obvious. CLAUDE.md updated to match..github/workflows/compose-validate.ymlrunsdocker compose config --quieton every PR that touchesdocker-compose.ymlor.env.example. Mirrors the validation step the CONTRIBUTING guide already asks contributors to run locally.Type of change
chore/)docs/)Validation
docker compose config --quietpasses locally withcp .env.example .env+ filled-in Tracearr secretsRelated
Follows up on #32, #33, and #34. Resolves the env-file confusion raised in discussion #4.
Summary by CodeRabbit
Release Notes
New Features
Documentation
Chores