Skip to content

Commit e3e7ad2

Browse files
committed
no real code changes
1 parent 5d0440c commit e3e7ad2

File tree

3 files changed

+71
-1
lines changed

3 files changed

+71
-1
lines changed

notes/collision-cost-issues.txt

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,68 @@
1+
face-face degenerate cases actually do happen, where we end up underestimating the decrease in signed distance
2+
when I run python arm_to_joint.py in 5d0440cfb21a22d0152
3+
observe that two penazed collisions appear (table_link-r_forearm_link), which the convexification didn't know about
4+
5+
Before step
6+
==============
7+
8+
9+
[DEBUG] don't need to add or remove stuff
10+
[DEBUG] 46 objects in bullet world
11+
[DEBUG] CollisionCollector: adding collision table_link-r_forearm_link (0.0255)
12+
[DEBUG] CastVsAll checked 14 links and found 1 collisions
13+
[DEBUG] not using cached collision check
14+
15+
[DEBUG] don't need to add or remove stuff
16+
[DEBUG] 46 objects in bullet world
17+
[DEBUG] CollisionCollector: adding collision table_link-r_upper_arm_link (0.0580)
18+
[DEBUG] CollisionCollector: adding collision table_link-r_forearm_link (0.0282)
19+
[DEBUG] CollisionCollector: adding collision table_link-r_wrist_flex_link (0.0492)
20+
[DEBUG] CastVsAll checked 14 links and found 3 collisions
21+
[DEBUG] not using cached collision check
22+
23+
[DEBUG] don't need to add or remove stuff
24+
[DEBUG] 46 objects in bullet world
25+
[DEBUG] CollisionCollector: adding collision table_link-r_upper_arm_link (0.0580)
26+
[DEBUG] CollisionCollector: adding collision table_link-r_forearm_link (0.0449)
27+
[DEBUG] CollisionCollector: adding collision table_link-r_wrist_flex_link (0.0579)
28+
[DEBUG] CastVsAll checked 14 links and found 3 collisions
29+
[DEBUG] not using cached collision check
30+
31+
[DEBUG] don't need to add or remove stuff
32+
[DEBUG] 46 objects in bullet world
33+
[DEBUG] CollisionCollector: adding collision table_link-r_upper_arm_link (0.0632)
34+
[DEBUG] CastVsAll checked 14 links and found 1 collisions
35+
36+
37+
After step
38+
============
39+
40+
[DEBUG] don't need to add or remove stuff
41+
[DEBUG] 46 objects in bullet world
42+
[DEBUG] CollisionCollector: adding collision table_link-r_upper_arm_link (0.0649)
43+
[DEBUG] CollisionCollector: adding collision table_link-r_forearm_link (0.0223)
44+
[DEBUG] CollisionCollector: adding collision table_link-r_wrist_flex_link (0.0558)
45+
[DEBUG] CastVsAll checked 14 links and found 3 collisions
46+
[DEBUG] not using cached collision check
47+
48+
[DEBUG] don't need to add or remove stuff
49+
[DEBUG] 46 objects in bullet world
50+
[DEBUG] CollisionCollector: adding collision table_link-r_upper_arm_link (0.0562)
51+
[DEBUG] CollisionCollector: adding collision table_link-r_forearm_link (0.0237)
52+
[DEBUG] CollisionCollector: adding collision table_link-r_wrist_flex_link (0.0461)
53+
[DEBUG] CastVsAll checked 14 links and found 3 collisions
54+
[DEBUG] not using cached collision check
55+
56+
[DEBUG] don't need to add or remove stuff
57+
[DEBUG] 46 objects in bullet world
58+
[DEBUG] CollisionCollector: adding collision table_link-r_upper_arm_link (0.0562)
59+
[DEBUG] CollisionCollector: adding collision table_link-r_forearm_link (0.0510)
60+
[DEBUG] CollisionCollector: adding collision table_link-r_wrist_flex_link (0.0637)
61+
[DEBUG] CastVsAll checked 14 links and found 3 collisions
62+
[DEBUG] not using cached collision check
63+
64+
[DEBUG] don't need to add or remove stuff
65+
[DEBUG] 46 objects in bullet world
66+
[DEBUG] CollisionCollector: adding collision table_link-r_upper_arm_link (0.0649)
67+
[DEBUG] CastVsAll checked 14 links and found 1 collisions
68+

notes/trajopt-todo.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ filtermask arguments in collision_terms
1515
Eventually
1616
===========
1717

18+
do something about METERS
19+
1820
fix up bpmd interface
1921

2022
boost python arguments

src/trajopt/bullet_collision_checker.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ struct CollisionCollector : public btCollisionWorld::ContactResultCallback {
388388
const KinBody::Link* linkB = getLink(colObj1Wrap->getCollisionObject());
389389
m_collisions.push_back(Collision(linkA, linkB, toOR(cp.m_positionWorldOnA), toOR(cp.m_positionWorldOnB),
390390
toOR(cp.m_normalWorldOnB), cp.m_distance1));
391-
LOG_DEBUG("CollisionCollector: adding collision %s-%s", linkA->GetName().c_str(), linkB->GetName().c_str());
391+
LOG_DEBUG("CollisionCollector: adding collision %s-%s (%.4f)", linkA->GetName().c_str(), linkB->GetName().c_str(), cp.m_distance1);
392392
return 1;
393393
}
394394
bool needsCollision(btBroadphaseProxy* proxy0) const {

0 commit comments

Comments
 (0)