Replace spaces with dashes when naming branches#88
Open
zachrammell wants to merge 1 commit intojorio:masterfrom
Open
Replace spaces with dashes when naming branches#88zachrammell wants to merge 1 commit intojorio:masterfrom
zachrammell wants to merge 1 commit intojorio:masterfrom
Conversation
Owner
|
Good idea, and I appreciate the test! I suggest installing a QValidator into the QLineEdit. This way we don't need to fiddle with the cursor. class ReplaceSpacesWithDashes(QValidator):
def validate(self, text: str, pos: int) -> tuple[QValidator.State, str, int]:
text = text.replace(" ", "-")
return QValidator.State.Acceptable, text, pos
...
...nameEdit.setValidator(...)Also, please avoid editing Feel free to connect any signals/validators in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small quality-of-life change to make using the
New BranchandRename Branchmenus feel more natural. Since spaces in branch names are invalid, this will interactively replace spaces with dashes while typing, ensuring that the input remains valid.